D6271: rust-filepatterns: add a Rust implementation of pattern-related utils
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Wed Apr 24 08:32:04 EDT 2019
Alphare added inline comments.
> kevincox wrote in filepatterns.rs:61
> I don't understand. The example I showed would give a boolean. The only difference I see is that the returned value would be 1 less (because .position() wouldn't count the skipped element) but this should be easy to handle in the code and I think would be more clear overall.
You're right, I was chasing the wrong problem. This is indeed more semantic.
To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel
More information about the Mercurial-devel