D6308: context: check file exists before getting data from _wrappedctx

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Apr 24 13:35:48 EDT 2019


martinvonz added inline comments.

INLINE COMMENTS

> context.py:1827
>              if self._cache[path]['exists']:
>                  if self._cache[path]['data']:
>                      return self._cache[path]['data']

I would have expected the only change to be to add ` is not None` to this line. Isn't that enough?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6308

To: pulkit, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list