D6308: context: check file exists before getting data from _wrappedctx

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Apr 24 14:00:00 EDT 2019


pulkit added inline comments.

INLINE COMMENTS

> martinvonz wrote in context.py:1827
> I would have expected the only change to be to add ` is not None` to this line. Isn't that enough?

I was unable to find some code which can set this to `None`. If you look at write() below in line 1993, it makes sure data is not None.

I am not sure I understand what this if does. Do you have ideas?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6308

To: pulkit, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list