D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Apr 24 14:48:41 EDT 2019
martinvonz added inline comments.
> + at bundle2.parthandler('Narrowspec')
> +def _handlenarrowspecs(op, inpart):
Could you extract the name to a constant like `_SPECPART` etc? I'd also prefer it to start with `narrow:` like the other ones do (so maybe call it `narrow:Spec`?). Hmm, but `narrow:spec` and `narrow:Spec` are very likely to be confused, though. Perhaps this should be `narrow:Clientspec` or something? Or `narrow:Serverspec`? It's from the server, but it's for the client... Or can you think of a better name? Perhaps `narrow:ResponseSpec` or something like that?
To: pulkit, durin42, martinvonz, #hg-reviewers
Cc: idlsoft, mercurial-devel
More information about the Mercurial-devel