D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

idlsoft (Sandu Turcan) phabricator at mercurial-scm.org
Wed Apr 24 14:49:54 EDT 2019


idlsoft added inline comments.

INLINE COMMENTS

> narrowbundle2.py:167
> +        excludepats = set(exc.splitlines())
> +    narrowspec.validatepatterns(includepats)
> +    narrowspec.validatepatterns(excludepats)

shouldn't this be inside the if?
`includepats` and `excludepats` are not defined otherwise.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6310

To: pulkit, durin42, martinvonz, #hg-reviewers
Cc: idlsoft, mercurial-devel


More information about the Mercurial-devel mailing list