D6301: phabricator: fallback to reading metadata from diff for phabread
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Apr 24 15:10:08 EDT 2019
martinvonz added inline comments.
INLINE COMMENTS
> Kwan wrote in phabricator.py:926
> I didn't use `get` here because "dateCreated" is set by conduit, not the submitted data, so should always be present and valid (but will make it `get` if requested).
I'm not very good at using the phabricator interface, but it seems like this has been addressed since this line doesn't have a `get`. Can someone confirm?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6301
To: Kwan, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list