D6298: phabricator: include commit (node) and parent in the local:commits metadata

Kwan (Ian Moody) phabricator at mercurial-scm.org
Thu Apr 25 12:54:20 EDT 2019


Kwan added inline comments.

INLINE COMMENTS

> indygreg wrote in phabricator.py:403
> What about p2?

I left it out since the "hg:meta" code only writes p1 (` b'parent': ctx.p1().hex(),`) and `getdiffmeta` doesn't read p2 from either "hg:meta" or "local:commits":

  if len(commit.get(b'parents', ())) >= 1:
      meta[b'parent'] = commit[b'parents'][0]

Adding it to all three could be a followup.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6298

To: Kwan, #hg-reviewers
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list