[PATCH STABLE] inno: bump keyring to 18.0.1 to avoid AttributeError (issue6043)

[Gregory Szorc]

On Fri, Apr 26, 2019 at 9:10 PM Matt Harbison <mharbison72 at gmail.com> wrote:

> # HG changeset patch
> # User Matt Harbison <matt_harbison at yahoo.com>
> # Date 1556337169 14400
> #      Fri Apr 26 23:52:49 2019 -0400
> # Branch stable
> # Node ID 723ed44028963db5a657578ac358acd07e546daa
> # Parent  14589f1989e91a455597cee754ae8587f3725394
> inno: bump keyring to 18.0.1 to avoid AttributeError (issue6043)
>

Queued for stable, thanks.

The Windows packaging code copied what was being done in the wild by
current package maintainers, hence why keyring is present in the Inno
installer but not WiX. We should definitely talk about consolidating
behavior. To what I'm not sure: I'm not sure why various dependencies are
included...


>
> The error seems to be harmless, because it happens after closing the
> connection.
> For whatever reason, this isn't bundled with the Wix installer.
>
> https://github.com/jaraco/keyring/issues/386
>
> https://bitbucket.org/Mekk/mercurial_keyring/issues/63/attributeerror-during-process-finish-with
>
> diff --git a/contrib/packaging/inno/requirements.txt
> b/contrib/packaging/inno/requirements.txt
> --- a/contrib/packaging/inno/requirements.txt
> +++ b/contrib/packaging/inno/requirements.txt
> @@ -22,9 +22,9 @@ entrypoints==0.3 \
>
>  --hash=sha256:589f874b313739ad35be6e0cd7efde2a4e9b6fea91edcc34e58ecbb8dbe56d19
> \
>
>  --hash=sha256:c70dd71abe5a8c85e55e12c19bd91ccfeec11a6e99044204511f9ed547d48451
> \
>      # via keyring
> -keyring==18.0.0 \
> -
> --hash=sha256:12833d2b05d2055e0e25931184af9cd6a738f320a2264853cabbd8a3a0f0b65d
> \
> -
> --hash=sha256:ca33f5ccc542b9ffaa196ee9a33488069e5e7eac77d5b81969f8a3ce74d0230c
> +keyring==18.0.1 \
> +
> --hash=sha256:67d6cc0132bd77922725fae9f18366bb314fd8f95ff4d323a4df41890a96a838
> \
> +
> --hash=sha256:7b29ebfcf8678c4da531b2478a912eea01e80007e5ddca9ee0c7038cb3489ec6
>  pygments==2.3.1 \
>
>  --hash=sha256:5ffada19f6203563680669ee7f53b64dabbeb100eb51b61996085e99c03b284a
> \
>
>  --hash=sha256:e8218dd399a61674745138520d0d4cf2621d7e032439341bc3f647bff125818d
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20190426/38c3d1a2/attachment.html>