D6704: config: add defaultvalue template keyword

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Thu Aug 1 14:38:32 EDT 2019


durin42 added a comment.


  I like the feature, I'll go ahead and queue it with the str/bytestr thing fixed in flight. Thanks!

INLINE COMMENTS

> commands.py:1875
>          value = pycompat.bytestr(value)
> +        defaultvalue = str(ui.configdefault(section, name))
>          if fm.isplain():

you almost certainly want `pycompat.bytestr()` here and not `str()` for py3 compat reasons

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6704/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6704

To: navaneeth.suresh, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list