D6709: config: add --all flag to show all known configs
av6 (Anton Shestakov)
phabricator at mercurial-scm.org
Fri Aug 2 08:45:04 EDT 2019
This revision now requires changes to proceed.
av6 added inline comments.
av6 requested changes to this revision.
INLINE COMMENTS
> commands.py:1774
> @command('config|showconfig|debugconfig',
> - [('u', 'untrusted', None, _('show untrusted configuration options')),
> + [('a', 'all', None, _('show all known configuration options')),
> + ('u', 'untrusted', None, _('show untrusted configuration options')),
This needs a better description to differentiate this flag and the default mode (see line 1786).
> test-config.t:238
> + progress.format=['topic', 'bar', 'number', 'estimate']
> + devel-warn: config item requires an explicit default value: 'progress.width' at: /tmp/hgtests.Ps_zAY/install/lib/python/mercurial/commands.py:1876 (config)
> + progress.width=None
Certainly a good way to find all config options without default values, but in the final implementation of `showconfig -a` it should not produce any warnings (especially not developer warnings).
It's probably possible to add default values to some of the items this test found, but I think some of them are missing defaults by design (an obvious example being `alias..*`). In that case it might be better to just skip them.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6709/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6709
To: navaneeth.suresh, #hg-reviewers, av6
Cc: av6, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list