D6709: config: add --all flag to show all known configs
navaneeth.suresh (Navaneeth Suresh)
phabricator at mercurial-scm.org
Sat Aug 3 02:00:29 EDT 2019
navaneeth.suresh added inline comments.
navaneeth.suresh marked an inline comment as done.
INLINE COMMENTS
> av6 wrote in commands.py:1774
> This needs a better description to differentiate this flag and the default mode (see line 1786).
Could you please suggest something better?
> av6 wrote in test-config.t:238
> Certainly a good way to find all config options without default values, but in the final implementation of `showconfig -a` it should not produce any warnings (especially not developer warnings).
>
> It's probably possible to add default values to some of the items this test found, but I think some of them are missing defaults by design (an obvious example being `alias..*`). In that case it might be better to just skip them.
I have ignored the cases with `dynamicdefault`. But, there are three cases showing a `devel-warn: accessing unregistered config item` message. Couldn't figure out why it is coming.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6709/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6709
To: navaneeth.suresh, #hg-reviewers, av6
Cc: av6, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list