D6710: branchmap: properly refresh/warm all branchmap caches

[marmoute (Pierre-Yves David)]

marmoute added a comment.


  Overall principle seems good. I made couple of inline comment.

INLINE COMMENTS

> localrepo.py:2200
>              self.ui.debug('updating the branch cache\n')
> -            self.filtered('served').branchmap()
> -            self.filtered('served.hidden').branchmap()
> +            for filt in ['visible', 'visible-hidden', 'served.hidden']:
> +                self.filtered(filt).branchmap()

Should we have this list explicitly stored in a list next to the filtermap ? That would seems more robust to future changes.

> localrepo.py:2224
> +                filtered = self.filtered(filt)
> +                filtered.branchmap().write(filtered)
> +

Why the explicite write here ? We don't seems to need it for the previous section. Is this because if the cache of the previous subset is valid, the write would be skipped ?
If so, consider clarifying it in your comment.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6710/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6710

To: spectral, #hg-reviewers
Cc: marmoute, mercurial-devel