D6710: branchmap: properly refresh/warm all branchmap caches
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Sat Aug 3 07:45:14 EDT 2019
marmoute added a comment.
Overall principle seems good. I made couple of inline comment.
> self.ui.debug('updating the branch cache\n')
> - self.filtered('served').branchmap()
> - self.filtered('served.hidden').branchmap()
> + for filt in ['visible', 'visible-hidden', 'served.hidden']:
> + self.filtered(filt).branchmap()
Should we have this list explicitly stored in a list next to the filtermap ? That would seems more robust to future changes.
> + filtered = self.filtered(filt)
> + filtered.branchmap().write(filtered)
Why the explicite write here ? We don't seems to need it for the previous section. Is this because if the cache of the previous subset is valid, the write would be skipped ?
If so, consider clarifying it in your comment.
CHANGES SINCE LAST ACTION
To: spectral, #hg-reviewers
Cc: marmoute, mercurial-devel
More information about the Mercurial-devel