D6711: branchheads: store wdir-dependent caches in wcache (issue6181)

spectral (Kyle Lippincott) phabricator at mercurial-scm.org
Mon Aug 5 21:11:26 EDT 2019


spectral added a comment.


  In D6711#98248 <https://phab.mercurial-scm.org/D6711#98248>, @marmoute wrote:
  
  > The change looks good to me, However we probably want to introduce a new filter level 'wdir-independent-visible' to ensure we a good branchcache cache in .hg/cache that most share can use and that will be kept up to date. This also means we need to make sure it is warmed after transaction.
  
  I agree such a thing would be useful, and pretty easy to add (just needs to not remove items considered "pinned" during computehidden, but I'm a little concerned about the proliferation of these things. I think ideally we'd end up with:
  
  visible-hidden > visible > wdir-independent-visible > wdir-independent-served > wdir-independent-served.hidden > immutable > base
  and
  served > wdir-independent-served > wdir-independent-served.hidden > immutable > base
  and
  served.hidden > wdir-independent-served.hidden > immutable > base
  
  I think?
  
  (Not sure if we need a wdir-independent-visible-hidden, I still don't really understand visible-hidden, I just know that updating it actually breaks a Lot of stuff, so I avoided doing so in the first commit in the stack. :))

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6711/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6711

To: spectral, #hg-reviewers
Cc: marmoute, mercurial-devel


More information about the Mercurial-devel mailing list