D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Tue Aug 6 07:18:50 EDT 2019


pulkit added inline comments.

INLINE COMMENTS

> shelve.py:1008
>          if not ispartialunshelve:
>              _forgetunknownfiles(repo, shelvectx, addedbefore)
>              unshelvecleanup(ui, repo, basename, opts)

IIUC, we don't need `_forgetunknownfiles()` too in this if statement. Can you add some related tests and see if we need this as a followup?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6708/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6708

To: navaneeth.suresh, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list