D6709: config: add --registered flag to show all known configs

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Wed Aug 7 10:23:19 EDT 2019


This revision now requires changes to proceed.
marmoute added inline comments.
marmoute requested changes to this revision.

INLINE COMMENTS

> pulkit wrote in test-config.t:228
> In cases when the default value and the value of config set are different, let's do something like `<current-output> (default=<default_value>)`

Displaying the default vs current is good idea, but the current proposal might be a bit odd:

If nothing is set we will have:

  annotate.ignoreblanklines=False

If something is set and is the same as the default we'll have

  annotate.ignoreblanklines=False

If something is set and is different from the repo we will have

  annotate.ignoreblanklines=True (default: False)

The first two cases can't be distinguish while they probably should, and the default value is displayed differently between the first and third case.

> test-config.t:229
> +  $ hg showconfig --registered
> +  annotate.git=False
> +  annotate.ignoreblanklines=False

Note: we I think we should use `yes/no` instead of `True` and `False`.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6709/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6709

To: navaneeth.suresh, #hg-reviewers, av6, marmoute
Cc: pulkit, marmoute, av6, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list