D6720: config: fix defaultvalue template keyword (patch 2 of 2)

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Aug 7 10:24:33 EDT 2019


pulkit added a comment.


  This patch also needs a better description, something like: `config: fix fm.data() handling of defaultvalue`.

INLINE COMMENTS

> commands.py:1884
>          fm.condwrite(ui.debugflag, 'source', '%s: ', source)
> +        fm.data(name=entryname, defaultvalue=defaultvalue)
>          if uniquesel:

A better fix will be to move `fm.data(name=entryname)` inside the if, i.e. where it was before https://phab.mercurial-scm.org/D6704.

And add `fm.data(defaultvalue=...)` below the if-else which will also move the `defaultvalue` to last in json output.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6720/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6720

To: navaneeth.suresh, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list