D6720: config: fix fm.data() handling of defaultvalue
navaneeth.suresh (Navaneeth Suresh)
phabricator at mercurial-scm.org
Wed Aug 7 10:41:15 EDT 2019
navaneeth.suresh added inline comments.
INLINE COMMENTS
> pulkit wrote in commands.py:1884
> A better fix will be to move `fm.data(name=entryname)` inside the if, i.e. where it was before https://phab.mercurial-scm.org/D6704.
>
> And add `fm.data(defaultvalue=...)` below the if-else which will also move the `defaultvalue` to last in json output.
I did this but, couldn't see a difference in the test output.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6720/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6720
To: navaneeth.suresh, #hg-reviewers
Cc: pulkit, mercurial-devel
More information about the Mercurial-devel
mailing list