D6689: continue: added support for transplant

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Aug 7 17:57:16 EDT 2019


pulkit added inline comments.

INLINE COMMENTS

> transplant.py:743
> +        tp = transplanter(ui, repo, opts)
> +        tp.resume(repo, repo, opts)
> +        return

I don't see `transplanter` modifying opts. So we can directly pass empty dict in both of the above function.

> transplant.py:744
> +        tp.resume(repo, repo, opts)
> +        return
> +

`return tp.resume(..)` will be better here

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6689/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6689

To: taapas1128, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list