D6719: branchmap: refresh all "heads" of the branchmap subsets

[marmoute (Pierre-Yves David)]

This revision now requires changes to proceed.
marmoute added a comment.
marmoute requested changes to this revision.


  It seems like we are not warming enought cache with the new scheme.

INLINE COMMENTS

> localrepo.py:2204
> +                    filt = 'visible'
> +                self.filtered(filt).branchmap()
>  

We are no longer warming `served` explicitly If `served` and `served.hidden` are different this will be an issue (since `served` is much more used than `served.hidden`.

I would also add a `XXX` to the comment about `visible-hidden` to encourage people to investigate. This said. The same apply, we would need to warm both `visible` and `visible.hidden` explciitly.

> repoviewutil.py:28
> +# constant, so we just hard-code it.
> +subsettableheads = frozenset({'visible-hidden', 'served.hidden'})

Oops, it seems like `visible-hidden` and `served.hidden` has inconsistent naming. Feel free to fix that along the way.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6719/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6719

To: spectral, durin42, #hg-reviewers, marmoute
Cc: mercurial-devel