D6709: config: add --registered flag to show all known configs
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Fri Aug 9 14:52:42 EDT 2019
pulkit added inline comments.
INLINE COMMENTS
> commands.py:1888
> fm.condwrite(ui.debugflag, 'source', '%s: ', source)
> + fm.data(defaultvalue=defaultvalue)
> if uniquesel:
unrequired change I guess
> marmoute wrote in test-config.t:228
> Displaying the default vs current is good idea, but the current proposal might be a bit odd:
>
> If nothing is set we will have:
>
> annotate.ignoreblanklines=False
>
> If something is set and is the same as the default we'll have
>
> annotate.ignoreblanklines=False
>
> If something is set and is different from the repo we will have
>
> annotate.ignoreblanklines=True (default: False)
>
> The first two cases can't be distinguish while they probably should, and the default value is displayed differently between the first and third case.
In the second case above,
How about something like:
annotate.ignoreblanklines=False (default: False)
i.e. we show `(default ..)` if the user has set that config option.
> test-config.t:990
> + worker.backgroundclosemaxqueue=384
> + worker.backgroundcloseminfilecount=2048
> + worker.backgroundclosethreadcount=4
Can you add some tests for `hg config <some-config> --registered`?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6709/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6709
To: navaneeth.suresh, #hg-reviewers, av6, marmoute
Cc: pulkit, marmoute, av6, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list