D6709: config: add --registered flag to show all known configs
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Sun Aug 11 07:04:33 EDT 2019
marmoute added inline comments.
> navaneeth.suresh wrote in test-config.t:232
> that change was there in my patch one revision before. i was asked by @pulkit to modify it as of now. would you recommend writing `no` to `fm.data()` also? the `defaultvalue` was not in `pycompat.bytestr()` after @yuja's suggestion. it would be better if we consider that as a string and change the function accordingly if we want to modify it. otherwise, it should print `no` and store `False`, print `False` on `hg showconfig --Tjson` in `defaultvalue`.
We should be consistent when printing. And we should also be consistent when recording stuff in data.
I think it make sense to print human friendly version ('yes/no') and use the actual boolean value in data()/json
CHANGES SINCE LAST ACTION
To: navaneeth.suresh, #hg-reviewers, av6, marmoute
Cc: yuja, pulkit, marmoute, av6, mjpieters, mercurial-devel
More information about the Mercurial-devel