D6430: rust-discovery: using from Python code
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Wed Aug 14 16:12:09 EDT 2019
durin42 added a comment.
I'm not thrilled with this - it's a lot of code, and I think there are some simpler options that haven't been explored. For example, clients could use the logexchange infrastructure to prime the sampling process and do a lot better.
That said, it seems "fine" and I'm okay to land it with the understanding that if it becomes a maintenance burden we'll almost certainly rip it out in favor of the pure-Python codepath. I'm queueing it and will send a follow-up for one of my review comments.
CHANGES SINCE LAST ACTION
To: gracinet, #hg-reviewers
Cc: durin42, pulkit, marmoute, martinvonz, mercurial-devel
More information about the Mercurial-devel