D6725: tests: split joint repo/changelog fake into one for each type

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Aug 14 16:14:21 EDT 2019


durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  I'm just not comfortable with fakes that get overloaded for multiple
  types: too often it gets out of hand and becomes difficult to trace.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6725

AFFECTED FILES
  tests/test-rust-discovery.py

CHANGE DETAILS

diff --git a/tests/test-rust-discovery.py b/tests/test-rust-discovery.py
--- a/tests/test-rust-discovery.py
+++ b/tests/test-rust-discovery.py
@@ -31,11 +31,14 @@
     b'\x00\x00\x00\x00\x00\x00\x00\x00\x00'
     )
 
+class fakechangelog(object):
+    def __init__(self, idx):
+        self.index = idx
+
 class fakerepo(object):
     def __init__(self, idx):
         """Just make so that self.changelog.index is the given idx."""
-        self.index = idx
-        self.changelog = self
+        self.changelog = fakechangelog(idx)
 
 @unittest.skipIf(PartialDiscovery is None or cparsers is None,
                  "rustext or the C Extension parsers module "



To: durin42, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list