D6709: config: add --registered flag to show all known configs
av6 (Anton Shestakov)
phabricator at mercurial-scm.org
Fri Aug 16 03:51:16 EDT 2019
av6 added a comment.
It looks fine to me, one thing that could be improved is the output format of list values. For example, `progress.format`: its default value is shown to be `['topic', 'bar', 'number', 'estimate']`, but it doesn't match `hg help config.progress.format` (it says `default: topic bar number estimate`), and that is also not the format that users would need to use for the actual value in hgrc or using --config flag.
INLINE COMMENTS
> ui.py:825-826
> + for name, item in sorted(data.iteritems()):
> + if (item.default is not configitems.dynamicdefault and
> + not item.generic):
> + if ((section in ['debug', 'devel', 'experimental'] or
Nit: this condition could be made into another `if ...: continue` block just like the one below, making things less indented.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6709/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6709
To: navaneeth.suresh, #hg-reviewers, av6, marmoute, durin42
Cc: durin42, mharbison72, yuja, pulkit, marmoute, av6, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list