D6709: config: add --registered flag to show all known configs

av6 (Anton Shestakov) phabricator at mercurial-scm.org
Sat Aug 17 09:00:00 EDT 2019


av6 added inline comments.

INLINE COMMENTS

> ui.py:832
> +                    # Omit config items with dynamicdefault, devel,
> +                    # experimental and generic config opts.
> +                    continue

Nit: originally I was fine with two different `if ...: continue` blocks here, and I still think it would be better. Not only the condition here is fairly complex and spans multiple lines (so not easy to read), but this comment is not quite correct. We always omit items with dynamic defaults and generic items, but experimental (& etc) items are only omitted unless --verbose is given. Two comments in two if-blocks with two separate conditions here would be more readable.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6709/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6709

To: navaneeth.suresh, #hg-reviewers, av6, marmoute, durin42
Cc: durin42, mharbison72, yuja, pulkit, marmoute, av6, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list