D6741: interfaces: create a new folder for interfaces and move repository.py in it
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Tue Aug 20 11:17:49 EDT 2019
martinvonz added a comment.
In D6741#99030 <https://phab.mercurial-scm.org/D6741#99030>, @durin42 wrote:
> In D6741#99023 <https://phab.mercurial-scm.org/D6741#99023>, @pulkit wrote:
>> In D6741#98947 <https://phab.mercurial-scm.org/D6741#98947>, @martinvonz wrote:
>>>> I was trying to understand current interfaces and write new ones and I realized
>>>> we need to improve how current interfaces are organised.
>>> And what was the reason we need to improve it? I assume we don't really "need" to change it. Will it somehow help with future patches? Or you just like this structure better?
>> Looking through Augie's hgit patch, I found we need to add more interfaces and decided to work on adding for `store.basicstore`. I found all the current interfaces in repository.py which has grown very large. I decided to create a new file to have interface for the store class, and maybe a new one for dirstate too, and having them in a separate folder dedicated to interfaces will be nice.
> I'm inclined to agree - the repository.py file full of interfaces has gotten crufty. It'd be nice to split it out into more files by topic.
That makes sense to me too.
CHANGES SINCE LAST ACTION
To: pulkit, indygreg, durin42, martinvonz, #hg-reviewers
More information about the Mercurial-devel