[PATCH] makefile: run Rust tests if cargo is installed

Raphaël Gomès raphael.gomes at octobus.net
Thu Aug 22 01:47:30 EDT 2019


I'm not sure I agree, checking for execute this way seems very common 
and looks more semantic to me.

On 8/22/19 1:37 AM, Yuya Nishihara wrote:
> On Thu, 22 Aug 2019 08:31:50 +0900, Yuya Nishihara wrote:
>> On Wed, 21 Aug 2019 18:09:33 +0200, Raphaël Gomès wrote:
>>> # HG changeset patch
>>> # User Raphaël Gomès <rgomes at octobus.net>
>>> # Date 1566403010 -7200
>>> #      Wed Aug 21 17:56:50 2019 +0200
>>> # Branch stable
>>> # Node ID 5b9efc6098154fb5079f06b3c485b58363e0f43d
>>> # Parent  302dbc9d52beeb2ef677aa18b3fa005bbce2134e
>>> makefile: run Rust tests if cargo is installed
>>>
>>> While no particular minimum toolchain version is targeted as of yet, this
>>> serves as a first step to make more people/machines run the Rust tests.
>>>
>>> diff -r 302dbc9d52be -r 5b9efc609815 Makefile
>>> --- a/Makefile	Fri Aug 16 15:41:53 2019 +0300
>>> +++ b/Makefile	Wed Aug 21 17:56:50 2019 +0200
>>> @@ -110,8 +110,11 @@
>>>   check: tests
>>>   
>>>   tests:
>>> -	cd tests && $(PYTHON) run-tests.py $(TESTFLAGS)
>>> -
>>> +	if [ -x "$$(command -v cargo)" ]; then \
> And maybe -n ?. '-x ""' (empty string) seems wrong.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list