[PATCH STABLE V2] makefile: run Rust tests if cargo is installed

Yuya Nishihara yuya at tcha.org
Fri Aug 23 07:03:50 EDT 2019


On Fri, 23 Aug 2019 11:13:59 +0200, Joerg Sonnenberger wrote:
> On Fri, Aug 23, 2019 at 08:15:05AM +0900, Yuya Nishihara wrote:
> > On Thu, 22 Aug 2019 15:53:01 +0200, Joerg Sonnenberger wrote:
> > > On Thu, Aug 22, 2019 at 02:57:04PM +0200, Raphaël Gomès wrote:
> > > > diff -r 302dbc9d52be -r 450f65349bbe Makefile
> > > > --- a/Makefile	Fri Aug 16 15:41:53 2019 +0300
> > > > +++ b/Makefile	Wed Aug 21 17:56:50 2019 +0200
> > > > @@ -16,6 +16,7 @@
> > > >  export LC_ALL=C
> > > >  TESTFLAGS ?= $(shell echo $$HGTESTFLAGS)
> > > >  OSXVERSIONFLAGS ?= $(shell echo $$OSXVERSIONFLAGS)
> > > > +CARGO=cargo
> > > >  
> > > >  # Set this to e.g. "mingw32" to use a non-default compiler.
> > > >  COMPILER=
> > > 
> > > Please use ?= for CARGO too, makes it easier to override from the
> > > command line.
> > 
> > Command-line arguments supersedes ordinary make variables.
> 
> ...but environment variables don't.

That's good thing IMO. Better to not take arbitrary environment variables
unless -e|--environment-overrides is specified.


More information about the Mercurial-devel mailing list