D6765: rustfilepatterns: shorter code for concatenating slices

valentin.gatienbaron (Valentin Gatien-Baron) phabricator at mercurial-scm.org
Wed Aug 28 07:44:05 EDT 2019


valentin.gatienbaron added inline comments.

INLINE COMMENTS

> kevincox wrote in filepatterns.rs:161
> I don't think you need the `&_[..]`. https://rust.godbolt.org/z/Wo-vza

Indeed, although it took a compiler upgrade.
I don't really understand why the compiler accepts the change here but not in the other places. It seems a bit random to remove the borrow only here. What do you think about the next commit? It would remove the `&_[..]` more predictably.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6765/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6765

To: valentin.gatienbaron, #hg-reviewers, Alphare, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list