D7523: rust-hg-path: implement `Display` for `HgPath` and `HgPathBuf`
kevincox (Kevin Cox)
phabricator at mercurial-scm.org
Mon Dec 2 13:04:36 UTC 2019
This revision now requires changes to proceed.
kevincox added inline comments.
kevincox requested changes to this revision.
INLINE COMMENTS
> hg_path.rs:168
> + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
> + write!(f, "HgPath {{ {} }}", String::from_utf8_lossy(&self.inner))
> + }
This looks more like a `Debug` format than a `Display` format. For `Display I would just do `write!(f, "{}", String::from_utf8_lossy(&self.inner))`
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7523/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7523
To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list