[PATCH] mail: don't complain about a multi-word email.method config value

Julien Cristau jcristau at debian.org
Mon Dec 2 08:52:37 EST 2019


On Mon, Dec 02, 2019 at 10:08:39PM +0900, Yuya Nishihara wrote:
> On Mon, 2 Dec 2019 11:52:53 +0100, Julien Cristau wrote:
> > On Sat, Nov 30, 2019 at 01:40:53PM +0900, Yuya Nishihara wrote:
> > > b''.split() will return an empty list, and it's probably better to use
> > > procutil.shellsplit().
> > > 
> > I did consider that, OTOH _sendmail already does the .split(None, 1)[0],
> > so I followed that pattern.  I guess I can change that one too...
> 
> Good catch. I prefer fixing it, too.
> 
Re-sent as:
D7541 - created - 3f567faa8930: mail: use procutil.shellsplit instead of bytes.split to parse command
D7542 - created - 0e11d6856fdd: mail: don't complain about a multi-word email.method

Thanks for the review!
Julien


More information about the Mercurial-devel mailing list