D7525: rust-matchers: improve `Matcher` trait ergonomics

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Mon Dec 2 09:20:22 EST 2019


Alphare added inline comments.

INLINE COMMENTS

> kevincox wrote in matchers.rs:87
> Another option here would just to have a global empty hash set.

I feel like an `Option` is more explicit and less contrived, but yes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7525/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7525

To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list