D7542: mail: don't complain about a multi-word email.method
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Tue Dec 3 07:56:00 EST 2019
yuja added a comment.
> + command = procutil.shellsplit(method)
> + if not (command and procutil.findexe(command[0])):
This condition is correct, but `command[0]` would raise IndexError if
`not command`.
Maybe we'll need a helper function that does `shellsplit()` and returns
`command[0]` or `b''`.
> - _(b'%r specified as email transport, but not in PATH') % method
>
> + _(b'%r specified as email transport, but not in PATH') % command[0]
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7542/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7542
To: jcristau, #hg-reviewers
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list