D7544: subrepo: use pycompat.open directly instead of importing open from pycompat
spectral (Kyle Lippincott)
phabricator at mercurial-scm.org
Wed Dec 4 01:21:27 EST 2019
spectral added a comment.
In D7544#110954 <https://phab.mercurial-scm.org/D7544#110954>, @mharbison72 wrote:
> I don't think this is correct, because `open` is imported from `pycompat` at the top of the file, and that will `sysstr()` the mode. But this does seem confusing- see D7517 <https://phab.mercurial-scm.org/D7517>.
Ah, so it is. Since this is the only use of open in this file, I've switched to just using `pycompat.open` directly in this location. I'm also fine with just dropping this change.
CHANGES SINCE LAST ACTION
To: spectral, #hg-reviewers
Cc: mharbison72, mercurial-devel
More information about the Mercurial-devel