D7575: hg-core: vendor Facebook's configparser crate
quark (Jun Wu)
phabricator at mercurial-scm.org
Sat Dec 7 18:06:50 EST 2019
quark added inline comments.
INLINE COMMENTS
> config.rs:72
> + ///
> + /// If `path` is a directory, it is ignored.
> + /// If `path` is a file, it will be loaded directly.
You might want to revert D13875655 for the directory include feature, which has some test changes.
> generate_parser.py:103-107
> +// This file should really be just 3 lines:
> +//
> +// #[derive(Parser)]
> +// #[grammar = "spec.pest"]
> +// pub(crate) struct ConfigParser;
You might want to follow this and remove the generated code.
> hg.rs:141-144
> + // exitcodemask is blacklisted if exitcode is outside HGPLAINEXCEPT.
> + if !plain_exceptions.contains("exitcode") {
> + ui_blacklist.insert("exitcodemask".into());
> + }
You might want to remove these lines.
> hg.rs:262-263
> + //
> + // Unlike Mercurial, don't convert the "$PAGER" environment variable
> + // to "pager.pager" config.
> + //
You might want to respect `$PAGER`. We ignored it to reduce support burden for mis-configuration.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7575/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7575
To: indygreg, #hg-reviewers
Cc: quark, durin42, kevincox, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list