D7528: rust-matchers: add `FileMatcher` implementation

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Wed Dec 11 04:29:24 EST 2019


Alphare added inline comments.

INLINE COMMENTS

> martinvonz wrote in matchers.rs:136
> It would be slightly simpler if the paths were owned. It doesn't seem too expensive to take ownership of the paths. Do we have any call sites in this series that we can look at?

There is a single call site for now in D7529 <https://phab.mercurial-scm.org/D7529>, it's really straightforward.

Automated tools like CI can produce matchers with a lot of files and it seems to me not worth changing existing no-allocation code to get rid of a few lifetime annotations. Can we see if it gets too unwieldy?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7528/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7528

To: Alphare, #hg-reviewers
Cc: martinvonz, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list