D7576: hg-core: add configparser to library
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Thu Dec 12 14:57:56 EST 2019
Alphare added inline comments.
> Alphare wrote in Cargo.toml:14
> I wonder about this dependency. It uses 4 `usize` for every slice of bytes, and adds some overhead, albeit minimal, that I am trying to justify.
> Are we looking at reaping the benefits down the line? The crate itself is good quality, maintained by the Tokio people, so I'm not *too* worried about it being pre-1.0, but do we need this?
I know it doesn't matter at all, but the timing of this issue is just too funny not to share: https://github.com/tokio-rs/bytes/issues/340
CHANGES SINCE LAST ACTION
To: indygreg, #hg-reviewers
Cc: Alphare, durin42, kevincox, mercurial-devel
More information about the Mercurial-devel