D7617: fix: make example fix hgrc work in subdirs

spectral (Kyle Lippincott) phabricator at mercurial-scm.org
Thu Dec 12 19:31:30 EST 2019


spectral added a comment.
spectral planned changes to this revision.


  In D7617#112130 <https://phab.mercurial-scm.org/D7617#112130>, @mharbison72 wrote:
  
  > See D7065 <https://phab.mercurial-scm.org/D7065> and D7570 <https://phab.mercurial-scm.org/D7570>.  I didn't realize you could stack `set:` and the other patterns like this.
  
  As far as I know, set: isn't a pattern itself, it's a "hey, everything that comes after this is a fileset, not a glob".
  
  I'm OK waiting for D7570 <https://phab.mercurial-scm.org/D7570>, it's the main reason I split this out from the other two in this stack, but if we want to accept it before D7570 <https://phab.mercurial-scm.org/D7570> makes it in (unsure if it's currently blocked), I'm also OK with that.
  
  I think that the later commits are still useful, though: I don't think D7570 <https://phab.mercurial-scm.org/D7570> deals with `listfile`, and the configuration for clang-format is broken in other ways. I'll reorder them so this is tip instead of root.

INLINE COMMENTS

> fix.hgrc:2
>  [fix]
> -clang-format:command = clang-format --style file -i
> -clang-format:pattern = (**.c or **.cc or **.h) and not "listfile:contrib/clang-format-ignorelist"

Oops, split failure, this line should remain, I'll send an update.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7617/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7617

To: spectral, #hg-reviewers
Cc: mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list