D7570: match: resolve filesets against the passed `cwd`, not the current one

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Thu Dec 12 21:13:09 EST 2019


mharbison72 added a comment.


  In D7570#112206 <https://phab.mercurial-scm.org/D7570#112206>, @yuja wrote:
  
  >>   @yuja, what do you think?
  >
  > I'm okay with this, but I would add "# TODO:" comment to subrepo handling
  > so future readers can see the problem. And one more nit: since `cwd=b''` is
  > a valid path, we have to test `cwd is None` explicitly.
  
  Good catch.  I don't see the meaning of b'' in this context defined anywhere.  But since `subinclude:` uses it to define the matcher, I'm assuming that's all of the adjustment we need?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7570/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7570

To: mharbison72, #hg-reviewers, durin42
Cc: durin42, hooper, yuja, martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list