D7633: clone: extract helper for checking mutually exclusive args
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri Dec 13 03:24:29 EST 2019
martinvonz added inline comments.
INLINE COMMENTS
> dlax wrote in cmdutil.py:263
> The function name is a bit misleading; it looks like it would check that an option wasn't specified multiple times. Perhaps `check_exclusive_arguments`?
I don't think I'd be able to guess what a function by that name did either. `check_at_most_one_argument` seems clearer, but maybe too long. I'll wait a bit for other ideas before I change anything.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7633/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7633
To: martinvonz, #hg-reviewers
Cc: dlax, mercurial-devel
More information about the Mercurial-devel
mailing list