D7570: match: resolve filesets against the passed `cwd`, not the current one
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri Dec 13 14:52:54 EST 2019
martinvonz added a comment.
In D7570#112206 <https://phab.mercurial-scm.org/D7570#112206>, @yuja wrote:
>> > In D7570#111892 <https://phab.mercurial-scm.org/D7570#111892>, @durin42 wrote:
>> >> I'm happy with this, but didn't spend time figuring out if all concerns have been addressed (I'm mostly doing a fast triage path).
>> > I *think* they're addressed, but we there's no rush to get this in so let's give Yuya a chance to comment, because I'm not sure if the issue with subrepos is an existing or new issue.
>> @yuja, what do you think?
> I'm okay with this, but I would add "# TODO:" comment to subrepo handling
> so future readers can see the problem. And one more nit: since `cwd=b''` is
> a valid path, we have to test `cwd is None` explicitly.
@yuja, maybe I've addressed both comments with the two new patches I added to the stack?
CHANGES SINCE LAST ACTION
To: mharbison72, #hg-reviewers, durin42
Cc: durin42, hooper, yuja, martinvonz, mercurial-devel
More information about the Mercurial-devel