D7651: nodetree: simplify a conditionnal in shortesthexnodeidprefix
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Fri Dec 13 20:11:47 UTC 2019
marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
instead of try to catch some attribute error, we could just nicely look if the
attribute will be available. This make the code simpler to follow and less error
prone since we no longer rely on a wider attribute catching.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D7651
AFFECTED FILES
mercurial/scmutil.py
CHANGE DETAILS
diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
--- a/mercurial/scmutil.py
+++ b/mercurial/scmutil.py
@@ -545,12 +545,10 @@
if cache is not None:
nodetree = cache.get(b'disambiguationnodetree')
if not nodetree:
- try:
+ if util.safehasattr(parsers, 'nodetree'):
+ # The CExt is the only implementation to provide a nodetree
+ # class so far.
nodetree = parsers.nodetree(cl.index, len(revs))
- except AttributeError:
- # no native nodetree
- pass
- else:
for r in revs:
nodetree.insert(r)
if cache is not None:
To: marmoute, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list