D7633: clone: extract helper for checking mutually exclusive args

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Mon Dec 16 00:51:05 EST 2019


pulkit added inline comments.

INLINE COMMENTS

> martinvonz wrote in cmdutil.py:263
> I don't think I'd be able to guess what a function by that name did either.  `check_at_most_one_argument` seems clearer, but maybe too long. I'll wait a bit for other ideas before I change anything.

I agree that the current name can be bit misleading. `check_at_most_one_argument` seems clearer. Maybe `argument` -> `arg` will make it bit smaller ;)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7633/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7633

To: martinvonz, #hg-reviewers
Cc: pulkit, dlax, mercurial-devel


More information about the Mercurial-devel mailing list