D7649: match: make sure `root` argument is always an absolute path

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Mon Dec 16 21:00:54 EST 2019


mharbison72 added a comment.
mharbison72 accepted this revision.


  Windows has some very strange rules for paths, and I remember fixing a subrepo bug with a path in the form `C:foo`.  I tried these, and can't think of anything more we'd need to worry about.
  
    >>> import os
    >>> os.path.isabs("/")
    True
    >>> os.path.isabs("C:/")
    True
    >>> os.path.isabs("C:tests")
    False
  
  (The last one being at the root of the hg repo.)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7649/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7649

To: martinvonz, #hg-reviewers, mharbison72
Cc: mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list