D7570: match: resolve filesets against the passed `cwd`, not the current one

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Mon Dec 16 21:06:34 EST 2019


mharbison72 added a comment.


  In D7570#112809 <https://phab.mercurial-scm.org/D7570#112809>, @martinvonz wrote:
  
  > In D7570#112576 <https://phab.mercurial-scm.org/D7570#112576>, @mharbison72 wrote:
  >
  >> It looks like the two `if cwd is None` lines are still reverted to `if not cwd` by comparing diff 3 to 5.
  >
  > Oh, because you fixed that and then I overwrote your changes? Because I don't remember changing it.
  
  Yeah, that's probably all it was.
  
  > Anyway, should be fine now that `cwd` is an absolute path, right?
  
  Yeah, it looks like the way you handled it would still allow `cwd=''` input.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7570/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7570

To: mharbison72, #hg-reviewers, durin42
Cc: durin42, hooper, yuja, martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list