D7649: match: make sure `root` argument is always an absolute path
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Tue Dec 17 10:24:45 EST 2019
martinvonz added a comment.
In D7649#112837 <https://phab.mercurial-scm.org/D7649#112837>, @mharbison72 wrote:
> Windows has some very strange rules for paths, and I remember fixing a subrepo bug with a path in the form `C:foo`. I tried these, and can't think of anything more we'd need to worry about.
> >>> import os
> >>> os.path.isabs("/")
> >>> os.path.isabs("C:/")
> >>> os.path.isabs("C:tests")
> (The last one being at the root of the hg repo.)
Thanks for checking. I think that means we're okay with this series now. I won't queue it because I wrote some of it.
CHANGES SINCE LAST ACTION
To: martinvonz, #hg-reviewers, mharbison72
Cc: mharbison72, mercurial-devel
More information about the Mercurial-devel