D7641: rebase: use cmdutil.check_at_most_one_arg() for --confirm/--dry-run

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Tue Dec 17 10:32:45 EST 2019


yuja added a comment.


  >> Spotted in a later patch, need to replace `_` back to `-` before printing output.
  >
  > Strings are immutable in Python, so it wasn't actually replaced, right? Or do I misunderstand your concern?
  
  Maybe he meant `opts[b'dry_run']` vs `--dry-run`. `*args` should follow
  underscore naming, but the printed option names don't.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7641/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7641

To: martinvonz, #hg-reviewers, pulkit
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list