D7631: absorb: allowing committed changes to be absorbed into their ancestors
rdamazio (Rodrigo Damazio Bovendorp)
phabricator at mercurial-scm.org
Tue Dec 17 23:42:55 EST 2019
rdamazio added a comment.
> Can you describe the feature a bit in the commit message. Specific things which I feel are missing:
Done
> Also, it will be nice if you add an entry in releasenotes.
Done
INLINE COMMENTS
> pulkit wrote in absorb.py:993
> need to do more checks here about being public commit etc. `rewriteutil.precheck` should help.
Done. Notice that *technically* the user could do such an absorb while in the middle of a merge, but it sounds like a bad idea and inviting troubles, so I'm letting it also disallow that case. I'll be surprised if anyone even notices.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7631/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7631
To: rdamazio, #hg-reviewers
Cc: pulkit, quark, mercurial-devel
More information about the Mercurial-devel
mailing list