D7652: test: extract some generic data and utility from test-rust-ancestor.py

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Dec 18 01:12:42 EST 2019


martinvonz added inline comments.

INLINE COMMENTS

> marmoute wrote in revlog.py:34
> Can you clarify where you want a comma added ?

"C", "Extension", "parsers", "module", and maybe also "tests" are all nouns and I had trouble figuring out if any of them were used as verbs here (maybe "parsers" should be "parses", I speculated). I think this is much clearer (assuming it's still accurate):

`The C version of the "parsers" module is not available. It is needed for this test.`

> pulkit wrote in test-rust-ancestor.py:34
> this is the next one.

`The Rust version of the "ancestor" module is not available. It is needed for this test.`

> test-rust-ancestor.py:38-39
> +    rustext is None,
>      "rustext or the C Extension parsers module "
>      "ancestor relies on is not available",
>  )

`The Rust or C version of the "parsers" module, which the "ancestor" module relies on, is not available.`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7652/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7652

To: marmoute, #hg-reviewers
Cc: martinvonz, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list