D7649: match: make sure `root` argument is always an absolute path

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Dec 20 09:29:05 EST 2019


martinvonz added a comment.


  In D7649#113440 <https://phab.mercurial-scm.org/D7649#113440>, @pulkit wrote:
  
  > I am bit confused with `/repo` everywhere that whether that's the only valid or other forms can be valid also. I will prefer making existing root passed as absolute instead of replacing them with `/repo` (provided I understood correctly).
  
  I switched to `/repo` only to try to clarify that the path is the path to the repo (not some subdirectory). Want me to switch them back?
  
  > Also I am not sure, but does this counts as API change?
  
  I'm not sure if any extensions might have passed a relative path without noticing. Sure, we can add the (API) tag. Can you do that in flight? Or I can do it later if you want me to change some of the paths anyway.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7649/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7649

To: martinvonz, #hg-reviewers, mharbison72
Cc: pulkit, mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list